[sdk-metrics] Add experimental envvar for setting ExemplarFilter for histograms #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
added
pkg:OpenTelemetry
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5611 +/- ##
==========================================
+ Coverage 83.38% 85.70% +2.31%
==========================================
Files 297 254 -43
Lines 12531 11016 -1515
==========================================
- Hits 10449 9441 -1008
+ Misses 2082 1575 -507
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
reviewed
May 15, 2024
cijothomas
reviewed
May 15, 2024
| | Environment variable | Description | Notes | | ||
| | -------------------------- | -------------------------------------------------- |-------| | ||
| | `OTEL_METRICS_EXEMPLAR_FILTER` | Sets the default `ExemplarFilter` to use for all metrics. | Added in `1.9.0` | | ||
| | `OTEL_DOTNET_EXPERIMENTAL_METRICS_EXEMPLAR_FILTER_HISTOGRAMS` | Sets the default `ExemplarFilter` to use for histogram metrics. If not set than `OTEL_METRICS_EXEMPLAR_FILTER` also applies to histograms. | Experimental key (may be removed or changed in the future). Added in `1.9.0` | |
There was a problem hiding this comment.
Suggested change
| | `OTEL_DOTNET_EXPERIMENTAL_METRICS_EXEMPLAR_FILTER_HISTOGRAMS` | Sets the default `ExemplarFilter` to use for histogram metrics. If not set than `OTEL_METRICS_EXEMPLAR_FILTER` also applies to histograms. | Experimental key (may be removed or changed in the future). Added in `1.9.0` | | |
| | `OTEL_DOTNET_EXPERIMENTAL_METRICS_EXEMPLAR_FILTER_HISTOGRAMS` | Sets the default `ExemplarFilter` to use for histogram metrics. If not set, then `OTEL_METRICS_EXEMPLAR_FILTER` also applies to histograms. | Experimental key (may be removed or changed in the future). Added in `1.9.0` | |
There was a problem hiding this comment.
I changed this a bit for @vishweshbankwar's comment above.
cijothomas
reviewed
May 15, 2024
…deBlanch/opentelemetry-dotnet into sdk-exemplarfilter-histograms
cijothomas
reviewed
May 16, 2024
cijothomas
reviewed
May 16, 2024
| ExemplarFilterType? exemplarFilter; | ||
| if (!TryParseExemplarFilterFromConfigurationValue(configValue, out var exemplarFilter)) | ||
| { | ||
| OpenTelemetrySdkEventSource.Log.MeterProviderSdkEvent($"Exemplar filter configuration was found but the value '{configValue}' is invalid and will be ignored."); |
There was a problem hiding this comment.
should we be showing string interpolation in our own logging.. though this is just startup only!
cijothomas
reviewed
May 16, 2024
cijothomas
approved these changes
May 16, 2024
vishweshbankwar
approved these changes
May 16, 2024
rajkumar-rangaraj
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2527
Changes
OTEL_DOTNET_EXPERIMENTAL_METRICS_EXEMPLAR_FILTER_HISTOGRAMSwhich can be used to set the default SDKExemplarFilterfor histogram metrics.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes