Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared] Use CultureInfo.InvariantCulture in TagWriter #5700

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jun 17, 2024

Relates to #5585 (comment)

Changes

  • Use CultureInfo.InvariantCulture when calling Convert.ToString for tag/attribute values without explicit handling.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team June 17, 2024 17:46
@github-actions github-actions bot added pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package labels Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (6250307) to head (9db1e7e).
Report is 264 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5700      +/-   ##
==========================================
+ Coverage   83.38%   86.06%   +2.68%     
==========================================
  Files         297      254      -43     
  Lines       12531    11054    -1477     
==========================================
- Hits        10449     9514     -935     
+ Misses       2082     1540     -542     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 85.98% <ø> (?)
unittests-Project-Stable 86.05% <ø> (?)
unittests-Solution 86.05% <ø> (?)
unittests-UnstableCoreLibraries-Experimental 84.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 124 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 4af3df9 into open-telemetry:main Jun 18, 2024
52 checks passed
@CodeBlanch CodeBlanch deleted the shared-tagwriter-invariantculture branch June 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants