Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Console, Exporter.InMemory] Nullable #5765

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jul 26, 2024

Towards #3958

Changes

[Exporter.Console, Exporter.InMemory] Nullable

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.InMemory Issues related to OpenTelemetry.Exporter.InMemory NuGet package labels Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (6250307) to head (cc4ce14).
Report is 284 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5765      +/-   ##
==========================================
+ Coverage   83.38%   86.20%   +2.81%     
==========================================
  Files         297      256      -41     
  Lines       12531    11102    -1429     
==========================================
- Hits        10449     9570     -879     
+ Misses       2082     1532     -550     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.19% <0.00%> (?)
unittests-Project-Stable 86.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...xporter.Console/ConsoleExporterHelperExtensions.cs 0.00% <ø> (ø)
...porter.Console/ConsoleExporterLoggingExtensions.cs 0.00% <ø> (ø)
...porter.Console/ConsoleExporterMetricsExtensions.cs 0.00% <ø> (ø)
...penTelemetry.Exporter.InMemory/InMemoryExporter.cs 81.81% <ø> (ø)
...rter.InMemory/InMemoryExporterMetricsExtensions.cs 97.72% <ø> (ø)
...emetry.Exporter.Console/ConsoleActivityExporter.cs 48.33% <0.00%> (+0.05%) ⬆️
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)
...xporter.Console/Implementation/ConsoleTagWriter.cs 11.11% <0.00%> (ø)
...metry.Exporter.Console/ConsoleLogRecordExporter.cs 0.00% <0.00%> (ø)

... and 202 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review July 26, 2024 08:50
@Kielek Kielek requested a review from a team July 26, 2024 08:50
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 22a58aa into open-telemetry:main Jul 26, 2024
34 checks passed
@Kielek Kielek deleted the nullable-console-exporter branch July 26, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.InMemory Issues related to OpenTelemetry.Exporter.InMemory NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants