-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Workaround DI containers which create unregistered services #5808
[otlp] Workaround DI containers which create unregistered services #5808
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5808 +/- ##
==========================================
+ Coverage 83.38% 86.23% +2.84%
==========================================
Files 297 257 -40
Lines 12531 11150 -1381
==========================================
- Hits 10449 9615 -834
+ Misses 2082 1535 -547
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do you think that it is worth to add some additional DI to our coverage?
+1, if this is a scenario we would support, a test case is needed. |
I commented about that a bit on here and we discussed somewhat on the SIG this week. Short answer is I feel like we should do something but I don't know what that something is 🤣 I don't feel a test in OtlpExporter project would be super useful. Because any dev at any time in this repo or contrib who introduces a I just spun up this issue in runtime to see if there might be a better way to do it or if some other safe way could be added: dotnet/runtime#107153 |
What version can I expect to see this fix in? We need to get off 1.7.0 due to some vulnerability reports. |
Fixes #5537
Fixes #5803
Changes
UseOtlpExporterRegistration
from being instantiated without a registration when using Unity or Grace DI containersMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes