Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Add support for .NET 9 Advice API #5854

Conversation

rajkumar-rangaraj
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj commented Sep 20, 2024

Fixes #5487
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner September 20, 2024 23:57
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Sep 20, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.29%. Comparing base (6250307) to head (0dec04c).
Report is 324 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs 95.65% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5854      +/-   ##
==========================================
+ Coverage   83.38%   86.29%   +2.91%     
==========================================
  Files         297      257      -40     
  Lines       12531    11194    -1337     
==========================================
- Hits        10449     9660     -789     
+ Misses       2082     1534     -548     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.27% <95.65%> (?)
unittests-Project-Stable 86.24% <95.65%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs 88.98% <95.65%> (+2.31%) ⬆️

... and 225 files with indirect coverage changes

@cijothomas
Copy link
Member

@rajkumar-rangaraj Do you know if httpclient, aspnetcore started leveraging the advice for providing custom buckets ?

@rajkumar-rangaraj
Copy link
Contributor Author

@rajkumar-rangaraj Do you know if httpclient, aspnetcore started leveraging the advice for providing custom buckets ?

I haven't checked this part yet.

@CodeBlanch CodeBlanch changed the title [Draft] Add support for .NET 9 Advice API [sdk-metrics] Add support for .NET 9 Advice API Sep 23, 2024
@CodeBlanch CodeBlanch added the metrics Metrics signal related label Sep 23, 2024
@CodeBlanch
Copy link
Member

Definitely need a CHANGELOG for this one 😄

@cijothomas
Copy link
Member

@rajkumar-rangaraj Do you know if httpclient, aspnetcore started leveraging the advice for providing custom buckets ?

I haven't checked this part yet.

np! We just need to make sure we don't remove the hardcoded buckets that exist today in sdk, until that happens and old versions are out of support.

@cijothomas
Copy link
Member

Definitely need a CHANGELOG for this one 😄

I also suggest to document this near https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/metrics/customizing-the-sdk#explicit-bucket-histogram-aggregation and recommend users to leverage Advice, wherever feasible

@rajkumar-rangaraj
Copy link
Contributor Author

@rajkumar-rangaraj Do you know if httpclient, aspnetcore started leveraging the advice for providing custom buckets ?

I haven't checked this part yet.

np! We just need to make sure we don't remove the hardcoded buckets that exist today in sdk, until that happens and old versions are out of support.

Created an issue to track doc changes separately - #5855

@CodeBlanch CodeBlanch merged commit d650352 into open-telemetry:main Sep 23, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET 9 Advice API
4 participants