Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup W3CTraceContextTests #5858

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 24, 2024

Fixes #5832 (review) - part 3.

Changes

Cleanup W3CTraceContextTests after dropping support for .NET6

  • semi automatic cleanup of suggestions in this file.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

after dropping support for .NET6
@Kielek Kielek requested a review from a team as a code owner September 24, 2024 04:02
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (6250307) to head (037d27f).
Report is 327 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5858      +/-   ##
==========================================
+ Coverage   83.38%   86.30%   +2.91%     
==========================================
  Files         297      257      -40     
  Lines       12531    11185    -1346     
==========================================
- Hits        10449     9653     -796     
+ Misses       2082     1532     -550     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.28% <ø> (?)
unittests-Project-Stable 86.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 225 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 3a09a91 into open-telemetry:main Sep 24, 2024
31 checks passed
@Kielek Kielek deleted the cleanup-w3c-tests branch September 24, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants