Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Update verb tense grammar for CHANGELOGs #5940

Merged
merged 2 commits into from
Oct 31, 2024
Merged

[docs] Update verb tense grammar for CHANGELOGs #5940

merged 2 commits into from
Oct 31, 2024

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Oct 30, 2024

Address feedbacks at #5926 (comment).

Changes

Updated the verb tense grammar for CHANGELOGs.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated: N/A
  • Appropriate CHANGELOG.md files updated for non-trivial changes: N/A
  • Changes in public API reviewed (if applicable): N/A

@xiang17 xiang17 requested a review from a team as a code owner October 30, 2024 22:20
@github-actions github-actions bot added pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.InMemory Issues related to OpenTelemetry.Exporter.InMemory NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Oct 30, 2024
@xiang17 xiang17 mentioned this pull request Oct 30, 2024
Merged
4 tasks
@CodeBlanch CodeBlanch added the documentation Documentation related label Oct 31, 2024
@CodeBlanch CodeBlanch changed the title Update verb tense grammar for CHANGELOGs [docs] Update verb tense grammar for CHANGELOGs Oct 31, 2024
@CodeBlanch CodeBlanch merged commit 09b654e into open-telemetry:main Oct 31, 2024
19 checks passed
@xiang17 xiang17 deleted the xiang17/UpdateWordingInChangelogs branch October 31, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@Kielek Kielek Kielek approved these changes

Assignees
No one assigned
Labels
documentation Documentation related pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.InMemory Issues related to OpenTelemetry.Exporter.InMemory NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiang17 @Kielek @rajkumar-rangaraj @reyang @CodeBlanch