Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Stablize MetricPoint reclaim feature for delta aggregation #5956

Merged

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Nov 7, 2024

Fixes #5443
Design discussion issue #5443

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable): N/A

@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (6250307) to head (394275f).
Report is 377 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
+ Coverage   83.38%   86.56%   +3.17%     
==========================================
  Files         297      262      -35     
  Lines       12531    11782     -749     
==========================================
- Hits        10449    10199     -250     
+ Misses       2082     1583     -499     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.29% <100.00%> (?)
unittests-Project-Stable 86.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 86.17% <100.00%> (+5.78%) ⬆️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 93.30% <100.00%> (+5.46%) ⬆️
src/OpenTelemetry/Metrics/Metric.cs 97.24% <ø> (+0.71%) ⬆️
...c/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs 94.24% <100.00%> (ø)
...rc/OpenTelemetry/Metrics/Reader/MetricReaderExt.cs 91.81% <ø> (ø)

... and 237 files with indirect coverage changes

@github-actions github-actions bot added the documentation Documentation related label Nov 7, 2024
@xiang17 xiang17 marked this pull request as ready for review November 7, 2024 01:23
@xiang17 xiang17 requested a review from a team as a code owner November 7, 2024 01:23
@CodeBlanch CodeBlanch added the metrics Metrics signal related label Nov 7, 2024
@CodeBlanch CodeBlanch changed the title Stablize MetricPoint reclaim feature for delta aggregation [sdk-metrics] Stablize MetricPoint reclaim feature for delta aggregation Nov 7, 2024
docs/metrics/README.md Outdated Show resolved Hide resolved
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 112e17f into open-telemetry:main Nov 7, 2024
39 checks passed
@@ -16,10 +16,9 @@ public abstract class MetricSnapshotTestsBase
{
private readonly IConfiguration configuration;

protected MetricSnapshotTestsBase(bool shouldReclaimUnusedMetricPoints)
protected MetricSnapshotTestsBase()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiang17, can this class be fully removed and replaced by MetricSnapshotTests without any inheritance?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiang17 xiang17 deleted the xiang17/MetricPointsReclamation branch November 15, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote MetricPoint reclaim feature for delta aggregation from experimental to stable
4 participants