-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-metrics] Stablize MetricPoint reclaim feature for delta aggregation #5956
[sdk-metrics] Stablize MetricPoint reclaim feature for delta aggregation #5956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
==========================================
+ Coverage 83.38% 86.56% +3.17%
==========================================
Files 297 262 -35
Lines 12531 11782 -749
==========================================
- Hits 10449 10199 -250
+ Misses 2082 1583 -499
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,10 +16,9 @@ public abstract class MetricSnapshotTestsBase | |||
{ | |||
private readonly IConfiguration configuration; | |||
|
|||
protected MetricSnapshotTestsBase(bool shouldReclaimUnusedMetricPoints) | |||
protected MetricSnapshotTestsBase() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiang17, can this class be fully removed and replaced by MetricSnapshotTests without any inheritance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #5443
Design discussion issue #5443
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes