[repo] Updates for .NET 9 release #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5967 +/- ##
==========================================
+ Coverage 83.38% 86.85% +3.47%
==========================================
Files 297 263 -34
Lines 12531 12006 -525
==========================================
- Hits 10449 10428 -21
+ Misses 2082 1578 -504
Flags with carried forward coverage won't be shown. Click here to find out more. |
github-actions
bot
added
pkg:OpenTelemetry.Api.ProviderBuilderExtensions
CodeBlanch
commented
Nov 12, 2024
Comment on lines
-37
to
-39
| * Updated `Microsoft.Extensions.Hosting.Abstractions` package | ||
| version to `9.0.0-rc.1.24431.7`. | ||
| ([#5853](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5853)) |
There was a problem hiding this comment.
@rajkumar-rangaraj This was added here: https://github.com/open-telemetry/opentelemetry-dotnet/pull/5853/files#diff-1788690fb9e80d48d96d92320b51dc391560eb447490867db722279f47939d1eR25-R27
But OTLP doesn't have a dependency on Microsoft.Extensions.Hosting.Abstractions. Seems like a copy/paste issue? I just went ahead and removed it.
Kielek
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes