Metric Push Controller and basic config #599
Conversation
cijothomas
requested review from
bruno-garcia,
discostu105,
lmolkova,
MikeGoldsmith and
SergeyKanzhelev
as code owners
| } | ||
|
|
||
| [Event(18, Message = "Collection completed in '{0}' msecs.", Level = EventLevel.Informational)] | ||
| public void CollectionCompleted(long msec) |
There was a problem hiding this comment.
nit: seems like an unnecessary conversion of StopWatch to milliseconds. Would ticks work here?
| public abstract void Process(string meterName, string metricName, LabelSet labelSet, Aggregator<double> aggregator); | ||
|
|
||
| /// <summary> | ||
| /// Finish the current collection cycle and return the metrics. |
There was a problem hiding this comment.
I don't understand what this method does based on this description. Can you please make it more elaborate. Especially as it's very different from the SpanProcessor
There was a problem hiding this comment.
I added comments to make it clear that this is called at the end of every collection cycles. MetricProcessor can chose to clear it state (if its stateless) at this call.
(The spec for this are not yet final, so there may be some changes later)
This is not same as ShutDownAsync for SpanProcessor
|
@SergeyKanzhelev Thanks for detailed review! Addressed all of them. Please check again. |
|
@SergeyKanzhelev Please merge. I have follow up PRs waiting for this to be merged. |
Added PushController for Metrics.
Users can configure the Push interval, Batcher, Exporter using
MeterBuilder,MeterFactory(There are no SDK specs yet. Following similar approach as
Tracer. These may require changes once Meter SDK specs are finalized)#409 #390