Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] refactor constants #6010

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

TimothyMothra
Copy link
Contributor

Towards #5730

Changes

  • move Common constants from each signal file into separate file
  • cleanup constants files, add summary with link to original proto file
  • update serializer classes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@TimothyMothra TimothyMothra requested a review from a team as a code owner December 3, 2024 17:43
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.18%. Comparing base (b9be07a) to head (3ccb4a1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ntation/Serializer/ProtobufOtlpMetricSerializer.cs 75.00% 1 Missing ⚠️
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6010      +/-   ##
==========================================
+ Coverage   86.11%   86.18%   +0.06%     
==========================================
  Files         257      257              
  Lines       11690    11690              
==========================================
+ Hits        10067    10075       +8     
+ Misses       1623     1615       -8     
Flag Coverage Δ
unittests-Project-Experimental 86.06% <94.28%> (-0.01%) ⬇️
unittests-Project-Stable 86.14% <94.28%> (+0.39%) ⬆️
unittests-Solution ?
unittests-UnstableCoreLibraries-Experimental ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ementation/Serializer/ProtobufOtlpLogSerializer.cs 99.18% <100.00%> (ø)
...Implementation/Serializer/ProtobufOtlpTagWriter.cs 100.00% <100.00%> (ø)
...ntation/Serializer/ProtobufOtlpMetricSerializer.cs 99.15% <75.00%> (ø)
...entation/Serializer/ProtobufOtlpTraceSerializer.cs 92.72% <80.00%> (ø)

... and 5 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 0c775e5 into open-telemetry:main Dec 3, 2024
35 checks passed
@TimothyMothra TimothyMothra deleted the 202412_otlpConstants branch December 4, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants