Merge pull request #257 from wuunder/add_guard_register_tracer

Add guard to register_tracer
open-telemetry · Jul 2, 2021 · 9110035 · 9110035
2 parents 795848b + a7b5607
commit 9110035
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/apps/opentelemetry_api/src/opentelemetry.erl b/apps/opentelemetry_api/src/opentelemetry.erl
@@ -131,9 +131,11 @@ set_default_tracer(Tracer) ->
 set_tracer(Name, Tracer) ->
     verify_and_set_term(Tracer, Name, otel_tracer).
 
--spec register_tracer(atom(), string()) -> boolean().
-register_tracer(Name, Vsn) ->
-    otel_tracer_provider:register_tracer(Name, Vsn).
+-spec register_tracer(atom(), string() | binary()) -> boolean().
+register_tracer(Name, Vsn) when is_atom(Name) and is_binary(Vsn) ->
+    otel_tracer_provider:register_tracer(Name, Vsn);
+register_tracer(Name, Vsn) when is_atom(Name) and is_list(Vsn) ->
+    otel_tracer_provider:register_tracer(Name, list_to_binary(Vsn)).
 
 -spec register_application_tracer(atom()) -> boolean().
 register_application_tracer(Name) ->

diff --git a/apps/opentelemetry_api/src/otel_tracer_provider.erl b/apps/opentelemetry_api/src/otel_tracer_provider.erl
@@ -32,7 +32,7 @@
 -type cb_state() :: term().
 
 -callback init(term()) -> {ok, cb_state()}.
--callback register_tracer(atom(), string(), cb_state()) -> boolean().
+-callback register_tracer(atom(), binary(), cb_state()) -> boolean().
 -callback resource(cb_state()) -> term() | undefined.
 
 -record(state, {callback :: module(),
@@ -50,7 +50,7 @@ resource() ->
             undefined
     end.
 
--spec register_tracer(atom(), string()) -> boolean().
+-spec register_tracer(atom(), binary()) -> boolean().
 register_tracer(Name, Vsn) ->
     try
         gen_server:call(?MODULE, {register_tracer, Name, Vsn})