Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default samplers in SDK #116

Closed
tsloughter opened this issue Oct 1, 2020 · 0 comments
Closed

Update default samplers in SDK #116

tsloughter opened this issue Oct 1, 2020 · 0 comments
Assignees
@tsloughter
Labels
good first issue Good for newcomers help wanted Extra attention is needed language-erlang scope-sdk spec A change to the SDK specification that must be implemented.
Milestone
GA

Comments

@tsloughter
Copy link
Member

The samplers have changed slightly since they were implemented here. It may just be some name changes, so might be an easy update to do: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#traceidratiobased
@tsloughter tsloughter added help wanted Extra attention is needed good first issue Good for newcomers spec A change to the SDK specification that must be implemented. language-erlang scope-sdk labels Oct 1, 2020
@tsloughter tsloughter added this to the GA milestone Oct 6, 2020
@tsloughter tsloughter self-assigned this Oct 27, 2020
@tsloughter tsloughter mentioned this issue Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsloughter tsloughter

Labels
good first issue Good for newcomers help wanted Extra attention is needed language-erlang scope-sdk spec A change to the SDK specification that must be implemented.
Projects
None yet
Milestone
GA
Development

No branches or pull requests
1 participant
@tsloughter