Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update samplers to latest spec: parent_based & trace_id_ratio_based #127

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #127 into master will increase coverage by 0.07%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   31.78%   31.86%   +0.07%     
==========================================
  Files          63       63              
  Lines        2970     2972       +2     
==========================================
+ Hits          944      947       +3     
+ Misses       2026     2025       -1     
Flag Coverage Δ
#api 46.44% <ø> (ø)
#elixir 16.24% <ø> (ø)
#erlang 31.70% <82.60%> (+0.08%) ⬆️
#exporter 17.05% <ø> (ø)
#sdk 64.05% <82.60%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_sampler.erl 83.33% <82.60%> (+1.19%) ⬆️
apps/opentelemetry/src/otel_batch_processor.erl 73.56% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d12c51...d7a0e3d. Read the comment docs.

@tsloughter
Copy link
Member Author

Closes #116

@tsloughter tsloughter merged commit 15cba94 into open-telemetry:master Oct 28, 2020
@tsloughter tsloughter deleted the ratio-parent-based branch October 28, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants