Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new api function from_remote_span for propagated span context #265

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

tsloughter
Copy link
Member

Thanks to @dvic for catching this issue. Long story of how it happened but put simply it is both the result of spec churn (how remote spans were defined/stored changed multiple times) and relying on unit tests.

Note that the unit test issue is not fixed in this PR, so a follow up is needed with additional integration tests that propagate a span context and then runs the remote/local parent based samplers after extracting.

I had only been testing the sampler against span contexts defined in the tests instead of ones created by propagation, this meant is_remote was set properly in the test span_ctx even though it wouldn't be in actual usage when a span came through the propagator.

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #265 (a845aa6) into main (edfd222) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   36.39%   36.41%   +0.02%     
==========================================
  Files          37       37              
  Lines        3165     3166       +1     
==========================================
+ Hits         1152     1153       +1     
  Misses       2013     2013              
Flag Coverage Δ
api 62.90% <100.00%> (-0.14%) ⬇️
elixir 16.05% <0.00%> (-0.04%) ⬇️
erlang 36.41% <100.00%> (+0.02%) ⬆️
exporter 19.58% <ø> (ø)
sdk 79.10% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opentelemetry_api/src/otel_propagator_http_b3.erl 64.51% <100.00%> (ø)
...opentelemetry_api/src/otel_propagator_http_w3c.erl 50.90% <100.00%> (ø)
apps/opentelemetry_api/src/otel_tracer.erl 59.25% <100.00%> (-2.28%) ⬇️
apps/opentelemetry/src/otel_resource_detector.erl 92.85% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfd222...a845aa6. Read the comment docs.

@tsloughter tsloughter merged commit 3f79552 into open-telemetry:main Aug 9, 2021
@tsloughter tsloughter deleted the set-is-remote branch August 9, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants