use new api function from_remote_span for propagated span context #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @dvic for catching this issue. Long story of how it happened but put simply it is both the result of spec churn (how remote spans were defined/stored changed multiple times) and relying on unit tests.
Note that the unit test issue is not fixed in this PR, so a follow up is needed with additional integration tests that propagate a span context and then runs the remote/local parent based samplers after extracting.
I had only been testing the sampler against span contexts defined in the tests instead of ones created by propagation, this meant
is_remote
was set properly in the testspan_ctx
even though it wouldn't be in actual usage when a span came through the propagator.