Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removes macro that references missing function #309

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

isaacsanders
Copy link
Contributor

No description provided.

@isaacsanders isaacsanders requested a review from a team November 10, 2021 20:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 10, 2021

CLA Signed

The committers are authorized under a signed CLA.

@tsloughter
Copy link
Member

Woops, thanks! :) Yea, links is only able to be set at start of a span but that wasn't always the case.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #309 (ecef326) into main (b0f4c6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   37.90%   37.90%           
=======================================
  Files          49       49           
  Lines        3327     3327           
=======================================
  Hits         1261     1261           
  Misses       2066     2066           
Flag Coverage Δ
api 65.14% <ø> (ø)
elixir 14.59% <ø> (ø)
erlang 37.91% <ø> (ø)
exporter 19.75% <ø> (ø)
sdk 75.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f4c6b...ecef326. Read the comment docs.

@tsloughter
Copy link
Member

@isaacsanders can you sign the CLA? I'll merge once you do.

@tsloughter tsloughter merged commit 590d87f into open-telemetry:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants