Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional badges, fix w3c interop CI and correct the requirements #343

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

tsloughter
Copy link
Member

I can break this up if needed but figured they were all pretty uncontroversial changes, with the possible exception of the requirements, but I based that on what the CI is running.

@tsloughter tsloughter requested a review from a team January 4, 2022 20:41
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #343 (9b59e3c) into main (f12732d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          56       56           
  Lines        4563     4563           
=======================================
  Hits         1521     1521           
  Misses       3042     3042           
Flag Coverage Δ
api 67.28% <ø> (ø)
elixir 16.44% <ø> (ø)
erlang 33.27% <ø> (ø)
exporter 21.47% <ø> (ø)
sdk 77.13% <ø> (ø)
zipkin 2.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12732d...9b59e3c. Read the comment docs.

@ferd
Copy link
Member

ferd commented Jan 4, 2022

Approved but the CI spec seems wrong based on test results:

Run actions/checkout@v2
Error: Invalid repository 'https://github.com/w3c/trace-context'. Expected format {owner}/{repo}.

@tsloughter tsloughter force-pushed the badges-w3c branch 3 times, most recently from 699894f to 360b37f Compare January 4, 2022 22:50
README.md Show resolved Hide resolved
@tsloughter tsloughter merged commit 4d031fd into open-telemetry:main Jan 4, 2022
@tsloughter tsloughter deleted the badges-w3c branch January 4, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants