Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracestate: Keep last value for duplicate key #346

Merged
merged 6 commits into from
Jan 8, 2022

Conversation

tsloughter
Copy link
Member

This was recently updated in the W3C spec and they added tests we had to disable in order to pass because of the change. This patch fixes the decoding to keep the last value for any duplicate keys encountered and enables the strictest level of w3c interop tests.

Also a few patches that cleanup some docs stuff.

Tristan Sloughter added 5 commits January 6, 2022 13:33
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #346 (4cc68b0) into main (3e3281c) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   33.33%   33.55%   +0.21%     
==========================================
  Files          56       56              
  Lines        4563     4557       -6     
==========================================
+ Hits         1521     1529       +8     
+ Misses       3042     3028      -14     
Flag Coverage Δ
api 68.90% <100.00%> (+1.62%) ⬆️
elixir 16.47% <0.00%> (+0.02%) ⬆️
erlang 33.49% <100.00%> (+0.22%) ⬆️
exporter 21.47% <100.00%> (+<0.01%) ⬆️
sdk 77.13% <ø> (ø)
zipkin 2.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry_api/lib/open_telemetry.ex 21.42% <ø> (ø)
...elemetry_api/src/otel_propagator_trace_context.erl 70.83% <100.00%> (+19.81%) ⬆️
...ntelemetry_exporter/src/opentelemetry_exporter.erl 75.77% <100.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3281c...4cc68b0. Read the comment docs.

@tsloughter tsloughter merged commit 2fa1eda into open-telemetry:main Jan 8, 2022
@tsloughter tsloughter deleted the strict-trace-context branch January 8, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants