otelrestful: support WithPublicEndpoint and WithPublicEndpointFn #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
otelrestful_support_with_public_endpoint
branch
2 times, most recently
from
f92fab5 to
3cea463
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3563 +/- ##
=====================================
Coverage 69.9% 70.0%
=====================================
Files 147 147
Lines 6934 6948 +14
=====================================
+ Hits 4851 4865 +14
Misses 1959 1959
Partials 124 124
|
frzifus
force-pushed
the
otelrestful_support_with_public_endpoint
branch
3 times, most recently
from
ae97b00 to
865dc92
Compare
|
otelhttp also has |
|
sure - shouldn't be to much effort. |
frzifus
changed the title
|
Thank you! ❤️ |
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
otelrestful_support_with_public_endpoint
branch
from
9f6ea3f to
d65f28e
Compare
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
otelrestful_support_with_public_endpoint
branch
from
d65f28e to
18a53e6
Compare
|
done @dmathieu. Could have please have a look again? :) |
dmathieu
approved these changes
Mar 13, 2023
pellared
approved these changes
Mar 13, 2023
|
Is there something missing? :) |
|
Only maintainers can merge PRs. |
MrAlias
reviewed
Mar 17, 2023
instrumentation/github.com/emicklei/go-restful/otelrestful/config.go
Outdated
Show resolved
Hide resolved
…fig.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is strongly inspired by otlphttp.
Closes #3562