Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync aws sdk attributes with semantic conventions #3617

Merged
merged 13 commits into from
Mar 28, 2023

Conversation

nemoshlag
Copy link
Member

Solves #3521 for DynamoDB and AWS SDK.

Making AWS SDK attributes consistent with RPC clients:

1 Rename "aws.operation" attribute to "rpc.method"
2 Rename "aws.service" attribute to "rpc.service"
3 Add "rpc.system" attribute and set it to "aws-api" value

According to semconv

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #3617 (2a766a8) into main (5e79d2a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3617   +/-   ##
=====================================
  Coverage   70.0%   70.0%           
=====================================
  Files        147     147           
  Lines       6960    6963    +3     
=====================================
+ Hits        4874    4877    +3     
  Misses      1961    1961           
  Partials     125     125           
Impacted Files Coverage Δ
...git.luolix.top/aws/aws-sdk-go-v2/otelaws/attributes.go 82.3% <100.0%> (+2.3%) ⬆️
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go 94.2% <100.0%> (+<0.1%) ⬆️

@nemoshlag nemoshlag marked this pull request as ready for review March 21, 2023 13:58
@nemoshlag nemoshlag requested a review from a team March 21, 2023 13:58
@nemoshlag nemoshlag requested a review from Aneurysm9 as a code owner March 21, 2023 13:58
CHANGELOG.md Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit 78d106e into open-telemetry:main Mar 28, 2023
@nemoshlag nemoshlag deleted the semcov/aws-attr branch April 3, 2023 08:00
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants