Implement cloud.resource_id in AWS ECS detector #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5091 +/- ##
=====================================
Coverage 61.3% 61.3%
=====================================
Files 185 185
Lines 13882 13883 +1
=====================================
+ Hits 8511 8515 +4
+ Misses 5171 5169 -2
+ Partials 200 199 -1
|
MrAlias
approved these changes
Feb 14, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hanyuancheung
approved these changes
Feb 21, 2024
pellared
added
blocked: specification
pellared
approved these changes
Feb 21, 2024
|
@Aneurysm9, can you please take a look at this PR? |
zailic
pushed a commit
to zailic/opentelemetry-go-contrib
that referenced
this pull request
Mar 19, 2024
* implement cloud.resource_id in AWS ECS detector * add CHANGELOG entry * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the support for
cloud.resource_idas discussed in this issue insemantic-conventions.