Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelzap: Add skeleton for array encoder #5611

Merged
merged 9 commits into from
May 21, 2024

Conversation

khushijain21
Copy link
Contributor

Part of #5191

Pre-work #5279

This PR adds skeleton for arrayEncoder

@khushijain21 khushijain21 requested a review from pellared as a code owner May 20, 2024 09:01
@khushijain21 khushijain21 requested a review from a team May 20, 2024 09:01
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 63.2%. Comparing base (c47a69c) to head (b921532).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5611     +/-   ##
=======================================
- Coverage   63.3%   63.2%   -0.2%     
=======================================
  Files        194     194             
  Lines      11998   12024     +26     
=======================================
  Hits        7606    7606             
- Misses      4175    4201     +26     
  Partials     217     217             
Files Coverage Δ
bridges/otelzap/core.go 92.9% <ø> (ø)
bridges/otelzap/encoder.go 63.3% <0.0%> (-25.8%) ⬇️

@pellared

This comment was marked as resolved.

bridges/otelzap/core.go Outdated Show resolved Hide resolved
@pellared pellared merged commit e6f7c8e into open-telemetry:main May 21, 2024
22 of 23 checks passed
khushijain21 added a commit to khushijain21/opentelemetry-go-contrib that referenced this pull request May 22, 2024
@khushijain21 khushijain21 deleted the arrayencoder branch May 24, 2024 03:56
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants