Add Instrumentation for go-chi/chi
#986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com/gorilla/mux/otelmux format;
…TTPServerAttributesFromHTTPRequest(); add explanation comment why we execute the request first before setting up span attributes;
riandyrn
changed the title
go-chi/chigo-chi/chi
riandyrn
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
riandyrn
changed the title
go-chi/chigo-chi/chi
|
Hello, @pellared & @Aneurysm9 Is there maybe something I should improve from this PR? Thanks |
|
That is great to me. |
|
Thanks for the contribution. According to our new instrumentation policy, we are no longer accepting new instrumentation to the project as we do not have the developer bandwidth to support it. If you are able, please consider maintaining this instrumentation in your own repository and listing it in the the OpenTelemetry Registry. |
riandyrn
added a commit
to riandyrn/otelchi
that referenced
this pull request
Oct 18, 2021
…rib#986; simplify test structure;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update contains tracing instrumentation for https://github.com/go-chi/chi.
Inspired heavily by otelmux.
Tracing