Only set trace attributes if they exists

open-telemetry · Nov 9, 2024 · bad8fa3 · bad8fa3
1 parent df2e1ed
commit bad8fa3
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/internal/pkg/opentelemetry/controller.go b/internal/pkg/opentelemetry/controller.go
@@ -32,12 +32,16 @@ func (c *Controller) Trace(ss ptrace.ScopeSpans) {
 		kvs       []attribute.KeyValue
 	)
 
-	tracer := c.tracerProvider.Tracer(
-		ss.Scope().Name(),
+	to := []trace.TracerOption{
 		trace.WithInstrumentationVersion(ss.Scope().Version()),
-		trace.WithInstrumentationAttributes(attrs(ss.Scope().Attributes())...),
 		trace.WithSchemaURL(ss.SchemaUrl()),
-	)
+	}
+
+	if m := ss.Scope().Attributes(); m.Len() > 0 {
+		to = append(to, trace.WithInstrumentationAttributes(attrs(m)...))
+	}
+
+	tracer := c.tracerProvider.Tracer(ss.Scope().Name(), to...)
 	for k := 0; k < ss.Spans().Len(); k++ {
 		pSpan := ss.Spans().At(k)