Use noop
instead of embedded
for auto/sdk
default implementations
#1228
Milestone
noop
instead of embedded
for auto/sdk
default implementations
#1228
opentelemetry-go-instrumentation/sdk/trace.go
Line 34 in 3eb8555
opentelemetry-go-instrumentation/sdk/trace.go
Lines 47 to 51 in 3eb8555
opentelemetry-go-instrumentation/sdk/trace.go
Lines 142 to 150 in 3eb8555
The
embedded
package will cause compilation errors when the implementation of the Go Trace API is not satisfied by an implementation.Currently this is not an issue because the
sdk
package fully implements the Trace API. However if ...auto/sdk
implementation, therefore ...auto/sdk
needs to add the missing methods so the global package can compileauto/sdk
needs to be publishedauto/sdk
to the one just releaseThis circular update path can be avoided if the
auto/sdk
package embeds thenoop
implementation of the Trace API. The global package can be updated without a new version fromauto/sdk
needed as the default behavior will be that it compiles and acts as a NoOp. When we are able to develop an implementation of the added method that can be brought into the global API afterwards.The text was updated successfully, but these errors were encountered: