Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple version ranges for traced field offsets #309

Closed
MrAlias opened this issue Sep 13, 2023 · 0 comments · Fixed by #342
Closed

Allow multiple version ranges for traced field offsets #309

MrAlias opened this issue Sep 13, 2023 · 0 comments · Fixed by #342
Assignees
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 13, 2023

Currently, our offset data model expects a continuous range of supported field offsets and therefore only allows one version range per:

// TrackedStruct maps fields names to the tracked fields offsets.
type TrackedStruct map[string]TrackedField

As has been shown in #273 where there is a break in the support of gRPC (

{
"versions": {
"oldest": "1.0.0",
"newest": "1.0.4"
},
"offsets": [
{
"offset": 8,
"since": "1.0.0"
}
]
},
{
"versions": {
"oldest": "1.3.0",
"newest": "1.59.0-dev"
},
"offsets": [
{
"offset": 8,
"since": "1.3.0"
}
]
}
), it is not always the case that we will be able to support continuous ranges of package versions.

We should instead define the TracedStruct as:

type TrackedStruct map[string][]TrackedField

And track each version range.

Related to #271
Blocked by #307 (once merged we can fix this in a single spot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant