Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify offset data model #307

Merged
merged 20 commits into from
Sep 21, 2023
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 13, 2023

The offsets generation currently uses a copy of the pkg/inject data model, this introduces a bug if they become out of sync. This change unifies on the pkg/inject data model to be used for both. It also adds a helper method to the TrackedOffsets to remove duplicate lookup logic in both packages.

Resolves #291

@MrAlias

This comment was marked as outdated.

@MrAlias MrAlias force-pushed the unify-offset-data-model branch from 6a4ce16 to a11c3f3 Compare September 18, 2023 18:15
@MrAlias MrAlias merged commit 9a15c1a into open-telemetry:main Sep 21, 2023
@MrAlias MrAlias deleted the unify-offset-data-model branch September 21, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the data model between the offsets-tracker and pkg/inject
3 participants