[PoC] Switch to pdata as data-model #1177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
pdata-datamodel
branch
from
044634e to
22bac67
Compare
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
MrAlias
force-pushed
the
pdata-datamodel
branch
from
22bac67 to
f7bff82
Compare
RonFed
reviewed
Nov 1, 2024
| // | ||
| // If OTEL_TRACES_EXPORTER is defined, this option will conflict with | ||
| // [WithEnv]. If both are used, the last one provided to an [Instrumentation] | ||
| // will be used. | ||
| func WithTraceExporter(exp trace.SpanExporter) InstrumentationOption { | ||
| func WithTraceHandler(handler TraceHandler) InstrumentationOption { |
There was a problem hiding this comment.
I think we should keep having a way of just configuring the exporter without having to configure a complete handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.