Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry/test package #1194

Merged
merged 4 commits into from
Oct 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test Span flags
The collector issue blocking this was resolved.
MrAlias committed Oct 15, 2024

Verified

This commit was signed with the committer’s verified signature.
MrAlias Tyler Yahn
commit f685805ed58b56fbccee55d635ba87333abd4faa
20 changes: 9 additions & 11 deletions sdk/telemetry/test/conversion_test.go
Original file line number Diff line number Diff line change
@@ -67,8 +67,8 @@ var (
TraceState: "test=green",
Attrs: []telemetry.Attr{telemetry.Int("queue", 17)},
DroppedAttrs: 8,
// https://github.com/open-telemetry/opentelemetry-collector/issues/11267
// Flags: 1,
// https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1196
// Flags: 1,
}
pLink = func() ptrace.SpanLink {
l := ptrace.NewSpanLink()
@@ -77,7 +77,7 @@ var (
l.TraceState().FromRaw("test=green")
l.Attributes().PutInt("queue", 17)
l.SetDroppedAttributesCount(8)
// https://github.com/open-telemetry/opentelemetry-collector/issues/11267
// https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1196
// l.SetFlags(1)
return l
}()
@@ -98,12 +98,11 @@ var (
}()

spanA = &telemetry.Span{
TraceID: [16]byte{0x1},
SpanID: [8]byte{0x2},
TraceState: "test=a",
ParentSpanID: [8]byte{0x1},
// https://github.com/open-telemetry/opentelemetry-collector/issues/11267
// Flags: 1,
TraceID: [16]byte{0x1},
SpanID: [8]byte{0x2},
TraceState: "test=a",
ParentSpanID: [8]byte{0x1},
Flags: 1,
Name: "span.a",
Kind: telemetry.SpanKindClient,
StartTime: y2k,
@@ -128,8 +127,7 @@ var (
ts.FromRaw("test=a")

s.SetParentSpanID(pcommon.SpanID([8]byte{0x1}))
// https://github.com/open-telemetry/opentelemetry-collector/issues/11267
// s.SetFlags(1)
s.SetFlags(1)
s.SetName("span.a")
s.SetKind(ptrace.SpanKindClient)
s.SetStartTimestamp(pcommon.NewTimestampFromTime(y2k))