-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gRPC status for versions >=1.40 #1235
Conversation
Can you add a changelog mentioning the fix and what support restrictions this introduces? |
I was able to manually test this with a grpc example and realized the error was coming from earlier than my first commits, so I switched to using StructFieldConstMinVersion (thanks @RonFed! forgot we had that) Writing down my repro steps: Tested by cloning https://github.com/grpc/grpc-go/tree/v1.39.x and building an image with this Dockerfile: FROM golang:latest
RUN mkdir -p /app
WORKDIR /app
COPY . .
ENV GOPATH /app
RUN cd examples/helloworld/greeter_client && go install .
RUN cd examples/helloworld/greeter_server && go install . Then loaded that image into a kind cluster and created this pod (along with a jaeger service):
Without 6fa573c, I got the same error from the auto-instrumentation pod as reported in #1225 (comment). After adding that commit, it seems to work:
|
The
Status
fields for gRPC have changed several times. Since we only recently added support for parsing the gRPC status into auto-instrumentation, I think it is reasonable to add a gate to only support the Status for recent versions (that have the same field format), rather than adding various checks for every version of gRPC.Working on testing this manually
Fixes #1225