Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL_GO_AUTO_SHOW_VERIFIER_LOG env var #128

Merged
merged 13 commits into from
May 3, 2023

Conversation

edeNFed
Copy link
Contributor

@edeNFed edeNFed commented May 1, 2023

Recent versions of cilium/ebpf library stopped printing detailed verifier logs by default.
This makes it hard to debug verifier errors (like #78).
This PR adds an additional env var called OTEL_GO_AUTO_SHOW_VERIFIER_LOG which will print the full verifier log if set to true.
Collecting verifier logs is an expensive operation, and therefore is turned off by default.

@edeNFed edeNFed requested a review from a team May 1, 2023 15:39
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. I've left a couple of queries regarding default values.

pkg/instrumentors/utils/ebpf.go Outdated Show resolved Hide resolved
pkg/instrumentors/utils/ebpf.go Show resolved Hide resolved
@MikeGoldsmith MikeGoldsmith changed the title add OTEL_GO_AUTO_SHOW_VERIFIER_LOG env var Add OTEL_GO_AUTO_SHOW_VERIFIER_LOG env var May 2, 2023
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I think a comment / issue to review LogSize configuration would be good 👍🏻

@MrAlias MrAlias mentioned this pull request May 2, 2023
pkg/instrumentors/utils/ebpf.go Outdated Show resolved Hide resolved
pkg/instrumentors/utils/ebpf.go Show resolved Hide resolved
pkg/instrumentors/utils/ebpf.go Outdated Show resolved Hide resolved
edeNFed and others added 5 commits May 3, 2023 04:29
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 5f09dbd into open-telemetry:main May 3, 2023
@MrAlias MrAlias mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants