-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTEL_GO_AUTO_SHOW_VERIFIER_LOG env var #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me. I've left a couple of queries regarding default values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I think a comment / issue to review LogSize configuration would be good 👍🏻
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Recent versions of cilium/ebpf library stopped printing detailed verifier logs by default.
This makes it hard to debug verifier errors (like #78).
This PR adds an additional env var called
OTEL_GO_AUTO_SHOW_VERIFIER_LOG
which will print the full verifier log if set to true.Collecting verifier logs is an expensive operation, and therefore is turned off by default.