[chore] Consolidate Docker image names #155
Conversation
Updates the Docker images creating during CI for testing and those published to the same name `otel-autoinstrumentation-go`
MasonLegere
changed the title
There was a problem hiding this comment.
Looks great, thanks @MasonLegere 👍🏻
PS I updated your PR description to automatically close #153 when this is merged.
There was a problem hiding this comment.
@MasonLegere failures are because the .github/workflows/kind.yml which run the e2e tests need updating too. There are other references to the old image name otel-go-instrumentation which should be update too.
…elemetry-go-instrumentation into consolidate-image-name
…elemetry-go-instrumentation into consolidate-image-name
|
@MasonLegere This is failing because the sample job isn't terminating correctly, you can see it here. My guess is that the kill command isn't finding the go instrumentation container to kill properly. Maybe there's more references to PS with docker + kubernetes and kind installed, you can check the e2e complete by running |
| @@ -10,7 +10,7 @@ jobs: | |||
| contents: read | |||
| packages: write | |||
| env: | |||
| IMAGE_NAME: autoinstrumentation-go | |||
| IMAGE_NAME: otel-autoinstrumentation-go | |||
There was a problem hiding this comment.
This will make the docker image otel/otel-autoinstrumentation-go. Do we want the stutter in the name?
There was a problem hiding this comment.
Hmm, no I don't think the additional otel prefix.
|
I'm going to update this PR to latest & fix build issues 👍🏻 |
|
This PR looks abandoned, closing. Please re-open if you are able to update this and address all the feedback. |
Consolidates the image name used locally and for testing with the same name published during releases resolving #153. This should be merged following #152 where it can be rebased to pull in the new registry changes.
Based on the information in the issue I set the name to
otel-autoinstrumentation-gowhich at 27 characters seems a bit verbose. Happy to change it to something else.