Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document we are not currently accepting new instrumentation probe PRs #1739

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 4, 2025

To prevent frustration for users submitting these PRs and to prevent churn and development burden by accepting these PRs document that we have paused accepting new instrumentation probe PRs.

@MrAlias MrAlias added the documentation Improvements or additions to documentation label Feb 4, 2025
@MrAlias MrAlias added this to the v0.21.0 milestone Feb 4, 2025
@MrAlias MrAlias requested a review from a team as a code owner February 4, 2025 17:19
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add guidance for users to still request instrumentations? Something like: "we are not currently implementing new libraries, but please feel free to submit a request by opening an issue"

I don't want to so strongly discourage people and it will also be helpful to get a running list of libraries to instrument with the new api

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Mike Dame <mike@odigos.io>
@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 4, 2025

Something like: "we are not currently implementing new libraries, but please feel free to submit a request by opening an issue"

Yeah, sounds like a good idea 👍

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 4, 2025

I'm going to add an issue template for new instrumentation requests that users can fill out.

@damemi
Copy link
Contributor

damemi commented Feb 4, 2025

@MrAlias great idea!

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 4, 2025

Include a label for the "new instrumentation".

CONTRIBUTING.md Outdated Show resolved Hide resolved
@MrAlias MrAlias force-pushed the doc-instr-restriction branch from 75b3f30 to 343c936 Compare February 4, 2025 19:59
@MrAlias MrAlias force-pushed the doc-instr-restriction branch from 343c936 to 6e4983c Compare February 4, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants