Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithServiceName config option for instrumentation #353

Merged
merged 10 commits into from
Sep 29, 2023

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Sep 27, 2023

There are 3 ways to set the service name with the following precedence from high to low:

  1. OTEL_SERVICE_NAME env var
  2. OTEL_RESOURCE_ATTRIBUTES env var
  3. WithServiceName InstrumentationOption

Default service name according to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/README.md#service

@RonFed RonFed requested a review from a team September 27, 2023 14:03
@RonFed RonFed changed the title Add WithServiceName condig option for instrumentation Add WithServiceName config option for instrumentation Sep 27, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
instrumentation.go Outdated Show resolved Hide resolved
instrumentation.go Show resolved Hide resolved
instrumentation.go Show resolved Hide resolved
RonFed and others added 2 commits September 27, 2023 19:03
instConfig_test.go Outdated Show resolved Hide resolved
instrumentation.go Outdated Show resolved Hide resolved
instrumentation.go Outdated Show resolved Hide resolved
instrumentation.go Outdated Show resolved Hide resolved
instrumentation.go Outdated Show resolved Hide resolved
RonFed and others added 2 commits September 29, 2023 11:33
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit d239377 into open-telemetry:main Sep 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants