Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Get Started doc with three scenarios #373

Merged

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Oct 13, 2023

Fixes #230
Fixes #231
Fixes #232
Fixes #204
Fixes #27

I've followed @pellared 's guidance here, but I'm pretty sure the instructions need more work and validation.

@theletterf theletterf requested a review from a team October 13, 2023 15:22
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested but I am pretty confident with my comments 😉

docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
theletterf and others added 5 commits October 16, 2023 11:33
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@pellared
Copy link
Member

@theletterf It looks like SYS_PTRACE is not needed anywhere #388

@theletterf
Copy link
Member Author

@MrAlias Robert and I checked and apparently SYS_PTRACE is not needed in any case. Is that so?

Also, kernel version 4.4 is a bit old (and EoL'd https://9to5linux.com/linux-kernel-4-4-lts-reaches-end-of-life-after-six-years-of-support). Could we raise the minimum kernel version to 4.19 at least? Seems like CVE-2022-0002 affects 4.18 and lower. https://security.snyk.io/vuln/SNYK-CENTOS8-KERNELMODULESEXTRA-2823043

docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
theletterf and others added 6 commits October 18, 2023 11:51
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
docs/get-started.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
docs/get-started.md Outdated Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member Author

This also solves #204 and #27.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
theletterf and others added 3 commits October 18, 2023 12:28
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@MrAlias MrAlias merged commit 664b363 into open-telemetry:main Oct 18, 2023
@MrAlias MrAlias added this to the v0.8.0-alpha milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants