Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otelglobal): fix multiple set attributes calls overwriting existing span attributes #634

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fix(otelglobal): fix multiple set attributes calls overwriting existing span attributes #634

merged 3 commits into from
Jan 29, 2024

Conversation

asecondo
Copy link
Contributor

@asecondo asecondo commented Jan 28, 2024 •
edited by MrAlias
Loading

Fix #592

asecondo
asecondo commented Jan 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@asecondo asecondo marked this pull request as ready for review January 28, 2024 21:31
@asecondo asecondo requested a review from a team January 28, 2024 21:31
RonFed
RonFed approved these changes Jan 29, 2024
View reviewed changes
internal/include/otel_types.h Show resolved Hide resolved
@MrAlias MrAlias merged commit 1ff2e6d into open-telemetry:main Jan 29, 2024
16 checks passed
@MrAlias MrAlias added this to the v0.11.0-alpha milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0-alpha
Development

Successfully merging this pull request may close these issues.

(otelglobal): issues when processing span.SetAttributes() multiple times on a recording span
3 participants
@asecondo @MrAlias @RonFed