Avoid using runtime.NumCPU to get the number of CPUs on the system #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime.NumCPUdoc states:This is problematic when the probed process is configured to run on a subset of the available CPUs.
In addition, we perform the above call for the agent process, so even if the probed process has some configuration for this, we won't see it.
This PR replaces this call with querying the relevant files to get the number of CPUs available in the system.
Adding a boundary check in
write_target_datato ensure that we are not writing to an un-mapped address if something goes wrong.