-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base Dockerfile and add caching for go build #683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RonFed could you please add some details about what this is doing? I also have a couple questions:
- Are we going to publish the new base image?
- What are the reasons for building a separate
.base
image over just multi-stage docker builds?
I'm assuming this helps with faster build times and maybe multi-arch builds? Is that just for our CI/builds or does that help users too?
Sure. The main motivation behind this is to make the build process faster for development. Running |
Thanks for the explanation @RonFed!
No, I think what you're doing here is right for that. I just wasn't sure what the main goal was so I wanted to pose that question. |
6c8614e
to
e8d699f
Compare
@damemi I figured it is possible to do it with one Dokcerfile and use the base as the first stage, so I modified it back to a single file.
|
No description provided.