[feat] Add ARM support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from odigos-io/opentelemetry-go-instrumentation#53 Co-authored-by: Eden Federman <eden@keyval.dev>
# Conflicts: # pkg/process/analyze.go
…trumentation into mike/arm # Conflicts: # Dockerfile
fix: add buildx to docker build command
edeNFed
reviewed
Apr 25, 2023
MrAlias
reviewed
Apr 28, 2023
pkg/instrumentors/bpf/github.com/gin-gonic/gin/bpf_bpfel.go
Outdated
Show resolved
Hide resolved
edeNFed
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Looks great. Depending on goroutine is a known bug. I started working on a fix in #118 so I don't think it is a blocker for this change.
Btw, I wonder if we can add e2e tests for ARM as well. We will probably need to request some ARM based GitHub runners for that (probably not part of this PR).
…trumentation into mike/arm # Conflicts: # pkg/instrumentors/bpf/net/http/server/probe.go
…trumentation into mike/arm
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…strumentation into mike/arm
|
@MrAlias I've addressed all feedback, this is ready for another review 👍🏻 |
MrAlias
approved these changes
May 2, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Adds support to build and run the agent and supporting tools on arm based architectures.
Includes the following changes:
serveHTTPandserveHTTP_returnsprobe callsBased the work contributed to keyval's original repo in the following PR:
There is shared work across the following PRs that has been combined into this PR:
The following PRs will need rebasing after this merges:
Co-authored-by: JamieDanielson jamieedanielson@gmail.com
Co-authored-by: Eden Federman eden@keyval.dev