Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make target 'codespell' #863

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Add make target 'codespell' #863

merged 11 commits into from
Jun 21, 2024

Conversation

rockdaboot
Copy link
Contributor

No description provided.

@rockdaboot rockdaboot requested a review from a team May 31, 2024 14:45
MrAlias
MrAlias reviewed May 31, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@rockdaboot rockdaboot force-pushed the spelling branch 2 times, most recently from 707762f to 0e9fdf3 Compare May 31, 2024 16:17
@rockdaboot rockdaboot changed the title Add make targets 'spellcheck' and 'spellcheck-fix' and fixed reported spelling errors Add make target 'codespell' and fixed reported spelling errors May 31, 2024
@rockdaboot rockdaboot changed the title Add make target 'codespell' and fixed reported spelling errors Add make target 'codespell' Jun 3, 2024
@rockdaboot
Copy link
Contributor Author

Extracted the actual fixes of spelling errors to #867

@rockdaboot
Copy link
Contributor Author

Extracted the actual fixes of spelling errors to #867

Now, the codespell make target is running locally. It is same as in https://github.com/open-telemetry/opentelemetry-go/blob/main/Makefile.

@rockdaboot rockdaboot requested review from pellared and MrAlias June 7, 2024 05:46
MrAlias
MrAlias reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One question about ignoring copied files though.

.codespellrc Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
RonFed
RonFed reviewed Jun 17, 2024
View reviewed changes
Makefile Show resolved Hide resolved
grcevski
grcevski approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrAlias MrAlias merged commit 6205485 into open-telemetry:main Jun 21, 2024
18 checks passed
@rockdaboot rockdaboot mentioned this pull request Jun 21, 2024
Closed
@MrAlias MrAlias mentioned this pull request Jul 15, 2024
Merged
@MrAlias MrAlias added this to the v0.14.0-alpha milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed left review comments

@grcevski grcevski grcevski approved these changes

@MrAlias MrAlias MrAlias approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0-alpha
Development

Successfully merging this pull request may close these issues.
5 participants
@rockdaboot @pellared @MrAlias @grcevski @RonFed