-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Validate instrument names when creating them (#4210)
* validate instrument names when creating them * add changelog entry * remove now invalid instrument name from prometheus test * fix invalid names in meter_test * keep returning the instrument even if its name is invalid * make invalid instrument name a known error * bring back prometheus invalid instrument name test * remove warning * fix lint * move name validation into the lookup method * fix lint again * Revert "move name validation into the lookup method" This reverts commit ec8ccc5. * rename ErrInvalidInstrumentName to ErrInstrumentName * switch to explicit validations, instead of a regexp * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * remove double check for empty name * test validation shortcut with a single character --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
- Loading branch information
1 parent
4f48154
commit 844b107
Showing
4 changed files
with
387 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.