Skip to content

Commit

Permalink
[chore] Fix codecov action usage (#5979)
Browse files Browse the repository at this point in the history
This change makes sure that an unsuccessful upload will fail the workflow as
this does not happen at the moment. See:
https://github.com/open-telemetry/opentelemetry-go/actions/runs/11845773487/job/33011997881?pr=5978#step:3:175

Additionally, it configures the codecov action to be tokenless.

Related issue (most likely solved):
- open-telemetry/community#2440


From
https://github.com/codecov/codecov-action?tab=readme-ov-file#migration-guide:

> The v5 release also coincides with the opt-out feature for tokens for
public repositories. In the repository settings page in codecov.io, you
can set the ability for Codecov to receive a coverage report from ANY
souce. This will allow contributors or other members of a repository to
upload without needing access to the Codecov token.

More codecov/codecov-action#1645

v4 was still working. See:
https://github.com/open-telemetry/opentelemetry-go/actions/runs/11842872629/job/33002565858#step:3:11
We might also consider reverting to v4 of the codecov action and just
setting `fail_ci_if_error: true`.
  • Loading branch information
pellared authored Nov 15, 2024
1 parent 128a6b8 commit f4ec01b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,8 @@ jobs:
pattern: coverage-artifacts-${{ env.DEFAULT_GO_VERSION }}
- name: Upload coverage report
uses: codecov/codecov-action@v5.0.0
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
fail_ci_if_error: true
files: ./coverage.txt
verbose: true

Expand Down

0 comments on commit f4ec01b

Please sign in to comment.