Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AddLink from Span interface #329

Closed
paivagustavo opened this issue Nov 18, 2019 · 5 comments
Closed

Remove AddLink from Span interface #329

paivagustavo opened this issue Nov 18, 2019 · 5 comments
Assignees
@VineethReddy02
Labels
good first issue Good for newcomers

Comments

@paivagustavo
Copy link
Member

From the specs, AddLink only exist during the creation of Span.
@paivagustavo paivagustavo mentioned this issue Nov 18, 2019
Closed
@paivagustavo paivagustavo changed the title AddLink is not a Span operation Remove AddLink from Span interface Nov 18, 2019
@jmacd jmacd added the good first issue Good for newcomers label Nov 21, 2019
@VineethReddy02
Copy link
Contributor

I will work on this! So the change involves removing AddLink from span interface right?

@paivagustavo
Copy link
Member Author

Hey @VineethReddy02, thanks for picking this up!

Yes, just remove it from the interface and also from its implementations (sdk span, noop_span and mock_span). We should also remove the Link method, just realized this now.

The only thing that must be kept is the addLink (unexported method) of the sdk span, that should be used during the span creation (tracer.Start()) when we have a trace.LinkedTo() option.

@VineethReddy02
Copy link
Contributor

I also see go.opentelemetry.io/otel/sdk/tracesdk/trace/tracer.go:62:7: span.AddLink undefined
So what exactly should I do at the places we are using ```AddLink``?

@paivagustavo
Copy link
Member Author

@VineethReddy02 that should be using the unexported addLink. But that rest should be removed.

@VineethReddy02 VineethReddy02 mentioned this issue Nov 25, 2019
Merged
@paivagustavo
Copy link
Member Author

paivagustavo commented Nov 26, 2019 •
edited
Loading

Closed with #349.

@iredelmeier iredelmeier mentioned this issue Nov 27, 2019
Closed
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@dependabot @MrAlias
Bump github.com/emicklei/go-restful/v3 from 3.3.0 to 3.3.1 in /instru…
5a11c85 
…mentation/github.com/emicklei/go-restful (#329)

* Bump github.com/emicklei/go-restful/v3

Bumps [github.com/emicklei/go-restful/v3](https://github.com/emicklei/go-restful) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/emicklei/go-restful/releases)
- [Changelog](https://github.com/emicklei/go-restful/blob/v3.3.1/CHANGES.md)
- [Commits](emicklei/go-restful@v3.3.0...v3.3.1)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@abh abh mentioned this issue Jan 27, 2024
Closed
@mladedav mladedav mentioned this issue Apr 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VineethReddy02 VineethReddy02

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmacd @paivagustavo @VineethReddy02