Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add add_link #1687

Closed
mladedav opened this issue Apr 28, 2024 · 2 comments
Closed

[Feature]: Add add_link #1687

mladedav opened this issue Apr 28, 2024 · 2 comments
Labels
enhancement New feature or request triage:todo Needs to be traiged.

Comments

@mladedav
Copy link

Related Problems?

Currently, links cannot be added to started spans.

#7 removed the method on a Span because it cited the spec as saying links can be added only during creation.

The doc now has it as a part of its stable API.

Describe the solution you'd like:

Add the method back.

Considered Alternatives

No response

Additional Context

The linked issue which removed the method also citied similar issue in go, but they have since added it back. The latter issue has some context.
@mladedav mladedav added enhancement New feature or request triage:todo Needs to be traiged. labels Apr 28, 2024
@lalitb
Copy link
Member

lalitb commented Apr 28, 2024

This has been added back as part of #1515

@TommyCpp
Copy link
Contributor

Close as completed

@TommyCpp TommyCpp closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage:todo Needs to be traiged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lalitb @TommyCpp @mladedav