-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metric identity and aggregation for duplicate instrument registration #3835
Comments
In the data model, there is nothing that makes any field case insensitive. Those would be instruments with different names. Is there something I am missing where these should be treated as the same instrument? |
I think the issue here is the API defines instrument names as case insensitive:
And the SDK "MUST aggregate data from identical Instruments together in its export pipeline." Where, "[t]he term identical applied to Instruments describes instances where all identifying fields are equal." With instrument's It seems like this issue is identifying that given the Go SDK does not aggregate data from instruments with case-insensitive identical names together it is not compliant with the specification. |
Specification issue asking what name to use in the above situation: open-telemetry/opentelemetry-specification#3539 |
Resolve open-telemetry#3835 Detect duplicate instrument registrations for instruments that have the same case-insensitive names. Continue to return the instruments with different names, but log a warning. This is the solution proposed in open-telemetry/opentelemetry-specification#3606.
* Detect dup inst for case-insensitive names Resolve #3835 Detect duplicate instrument registrations for instruments that have the same case-insensitive names. Continue to return the instruments with different names, but log a warning. This is the solution proposed in open-telemetry/opentelemetry-specification#3606. * Add changes to changelog * Reset global logger after test
Reopening as open-telemetry/opentelemetry-specification#3539 looks to be heading to a resolution other than what was done to resolve this. Currently we emit two streams, and the specification looks to be heading to a consensus to emit just the first-value and log a warning. |
Moved to being blocked by the specification issue: |
Description
https://github.com/open-telemetry/opentelemetry-specification/blob/ec84e5dcd77f36e79c0fe9bb1444d62be79dbb38/specification/metrics/sdk.md#duplicate-instrument-registration
Environment
Steps To Reproduce
request_counter
,request_Counter
,Request_Counter
Expected behavior
The text was updated successfully, but these errors were encountered: