Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling additional suffixes in prometheus exporter #4305

Closed
dashpole opened this issue Jul 11, 2023 · 0 comments · Fixed by #4306
Closed

Allow disabling additional suffixes in prometheus exporter #4305

dashpole opened this issue Jul 11, 2023 · 0 comments · Fixed by #4306
Assignees
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package

Comments

@dashpole
Copy link
Contributor

Problem Statement

When migrating from OpenCensus to OpenTelemetry, and using Prometheus exporters, it causes a breaking change in the metric name for counters that were not complying with Prometheus naming recommendations. For example, the metric my.metric.foo became my_metric_foo in OpenCensus. But in OpenTelemetry, it now becomes my_metric_foo_total.

Proposed Solution

I would like an option to disable additional suffixes on the Prometheus exporter.

Alternatives

Force breaking changes on users who migrate from OpenCensus.

Additional Context

This is currently required by the prometheus specification: If the metric name for monotonic Sum metric points does not end in a suffix of _total a suffix of _total MUST be added, otherwise the name MUST remain unchanged.. I'm planning to address this in the specification.

@dashpole dashpole added enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made labels Jul 11, 2023
@dashpole dashpole self-assigned this Jul 11, 2023
@dashpole dashpole removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Jul 13, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants