Prom compatibility: allow disabling the addition of _total suffixes on prometheus counters #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
allow_disable_suffix
branch
from
98ac1ac
to
72e615d
Compare
MrAlias
approved these changes
Jul 11, 2023
jmacd
approved these changes
Jul 11, 2023
reyang
approved these changes
Jul 11, 2023
pellared
approved these changes
Jul 13, 2023
howardjohn
approved these changes
Jul 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-go#4305
Motivation
When migrating from OpenCensus to OpenTelemetry, and using Prometheus exporters, it causes a breaking change in the metric name for counters that were not complying with Prometheus naming recommendations. This is because OpenCensus does not add
_totalsuffixes for counters. For example, the metricmy.metric.foobecamemy_metric_fooin OpenCensus. But in OpenTelemetry, it now becomesmy_metric_foo_total.Changes
Prometheus exporters should allow disabling the addition of
_totalsuffixes through configuration.cc @open-telemetry/wg-prometheus @jmacd @jsuereth