Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an sdk/internal/x package #5436

Closed
MrAlias opened this issue May 29, 2024 · 0 comments · Fixed by #5444
Closed

Add an sdk/internal/x package #5436

MrAlias opened this issue May 29, 2024 · 0 comments · Fixed by #5444
Assignees
@MrAlias
Labels
area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package
Milestone
v1.28.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented May 29, 2024

The following detectors are need to be added to comply with semantic conventions.

However, these detectors overlap with existing host and service detectors in this repository but they contain experimental semantics. To support these experimental semantics, we plan to extend the existing host and service resource detectors. This extension will be gated with an environment variable.

Similar to go.opentelemetry.io/otel/sdk/metric/internal/x, add an x package to facilitate this..
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:resources Part of OpenTelemetry resources labels May 29, 2024
@MrAlias MrAlias added this to the v1.28.0 milestone May 29, 2024
@MrAlias MrAlias self-assigned this May 29, 2024
@MrAlias MrAlias mentioned this issue May 30, 2024
Merged
MrAlias added a commit that referenced this issue Jun 5, 2024
@MrAlias @XSAM
Add the sdk/internal/x package (#5444)
c015059 
Add the `x` package to handle experimental feature flagging within the
go.opentelemetry.io/otel/sdk module. Currently this only supports
enabling experimental resource semantic conventions.

Resolve #5436 

cc @pyohannes

---------

Co-authored-by: Sam Xie <sam@samxie.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging a pull request may close this issue.

Add the sdk/internal/x package MrAlias/opentelemetry-go
1 participant
@MrAlias