Performance improvement: avoid creating multiple same read-only objects #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2104 +/- ##
=====================================
Coverage 72.8% 72.8%
=====================================
Files 166 166
Lines 8184 8185 +1
=====================================
+ Hits 5965 5966 +1
Misses 1989 1989
Partials 230 230
|
Aneurysm9
approved these changes
Jul 19, 2021
MrAlias
approved these changes
Jul 19, 2021
jmacd
approved these changes
Jul 19, 2021
XSAM
approved these changes
Jul 20, 2021
pellared
approved these changes
Jul 20, 2021
dashpole
approved these changes
Jul 20, 2021
MadVikingGod
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"snapshot" is read-only so same instance can be passed to multiple processors.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com