Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize MeterProvider readers field for new #2948

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Initialize MeterProvider readers field for new #2948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9c600e
Initialize MeterProvider readers field for new
MrAlias Jun 8, 2022
8e1ce03
Merge branch 'new_sdk/main' into init-mp-readers
MrAlias Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/metric/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ import (
type MeterProvider struct {
res *resource.Resource

meters meterRegistry
//nolint:structcheck,unused //This will be used by the MP to produce for a reader, and for the Meters to do proper view filtering
meters meterRegistry
readers map[Reader][]view.View

forceFlush, shutdown func(context.Context) error
Expand All @@ -56,6 +55,7 @@ func NewMeterProvider(options ...Option) *MeterProvider {

return &MeterProvider{
res: conf.res,
readers: conf.readers,
forceFlush: flush,
shutdown: sdown,
}
Expand Down